-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17434 fix markdown lint warnings #3633
Conversation
gh-pages.yml workflow changed to avoid running markdown linter on two .md files in .github folder. |
I'm confused. I got an email saying the run had failed, but this summary says "All checks have passed". Do you know where the markdownlint-cli warnings would appear (though hopefully there won't be any left)? |
CONTRIBUTING.md
Outdated
- **Corporate CLA**: If you have determined that a Corporate CLA is appropriate, please first check the [public list of Corporate CLAs][unicode-corporate-clas] that the Consortium has on file. If your employer is listed, then when you access the CLA Form, you can click the box indicating that you are covered by your employer’s corporate CLA. If your employer is not on the list, then it has not already signed a CLA and you will need to arrange for your employer to do so before you contribute, as described in [How to Sign a Unicode CLA][signing]. | ||
|
||
Unless otherwise noted in the [`LICENSE`](./LICENSE) file, this project is released under the [OSI-approved][osi-Unicode-License-3.0] free and open-source [Unicode License v3][unicode-license]. | ||
In order to contribute to this project, the Unicode Consortium must have on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't edit the "Contributor License Agreement" section. It is from the licensing team and is legally significant. I would revert this section and we can take a separate action to update this text up-stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srl295 This change was reverted. Ready for re-review.
I also edited the comment at the top to indicate that this PR won't close the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "Contributor License Agreement" part of CONTRIBUTING.md may not be updated here.
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
@DavidLRowe i'll add a comment on the ticket |
CLDR-17434
[Later edit] It seems that separate action will be needed to shorten the lines for the CLA section, as the source for that is elsewhere.
ALLOW_MANY_COMMITS=true